Messages in this thread | | | Date | Thu, 31 Aug 2023 18:38:01 +0530 | Subject | Re: [PATCH 2/9] phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver | From | Praveenkumar I <> |
| |
On 8/29/2023 10:25 PM, Krzysztof Kozlowski wrote: > On 29/08/2023 15:58, Praveenkumar I wrote: >> UNIPHY / Combo PHY used on various qualcomm SoC's are very similar to >> ipq4019 PHY. Hence renaming this driver to uniphy driver and can be >> used for other SoC's which are having the similar UNIPHY. >> >> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> >> --- >> MAINTAINERS | 7 ++++--- >> drivers/phy/qualcomm/Kconfig | 7 ++++--- >> drivers/phy/qualcomm/Makefile | 2 +- >> .../qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} | 0 >> 4 files changed, 9 insertions(+), 7 deletions(-) >> rename drivers/phy/qualcomm/{phy-qcom-ipq4019-usb.c => phy-qcom-uniphy.c} (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index ff1f273b4f36..7f4553c1a69a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -17774,13 +17774,14 @@ F: Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml >> F: drivers/mailbox/qcom-ipcc.c >> F: include/dt-bindings/mailbox/qcom-ipcc.h >> >> -QUALCOMM IPQ4019 USB PHY DRIVER >> +QUALCOMM UNIPHY DRIVER >> M: Robert Marko <robert.marko@sartura.hr> >> M: Luka Perkov <luka.perkov@sartura.hr> >> +M: Praveenkumar I <quic_ipkumar@quicinc.com> >> L: linux-arm-msm@vger.kernel.org >> S: Maintained >> -F: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml >> -F: drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c >> +F: Documentation/devicetree/bindings/phy/qcom,uniphy.yaml > You broke the path in your previous commit, but anyway this will go away. > >> +F: drivers/phy/qualcomm/phy-qcom-uniphy.c >> >> QUALCOMM IPQ4019 VQMMC REGULATOR DRIVER >> M: Robert Marko <robert.marko@sartura.hr> >> diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig >> index d891058b7c39..e6981bc212b3 100644 >> --- a/drivers/phy/qualcomm/Kconfig >> +++ b/drivers/phy/qualcomm/Kconfig >> @@ -28,12 +28,13 @@ config PHY_QCOM_EDP >> Enable this driver to support the Qualcomm eDP PHY found in various >> Qualcomm chipsets. >> >> -config PHY_QCOM_IPQ4019_USB >> - tristate "Qualcomm IPQ4019 USB PHY driver" >> +config PHY_QCOM_UNIPHY >> + tristate "Qualcomm UNIPHY driver" >> depends on OF && (ARCH_QCOM || COMPILE_TEST) >> select GENERIC_PHY >> help >> - Support for the USB PHY-s on Qualcomm IPQ40xx SoC-s. >> + Enable this driver to support the Qualcomm UNIPHY found in various >> + Qualcomm chipsets. > I don't quite get why this is renamed, either. Just because you re-use > it? Re-usage is not affected with old name... Understood. As suggested by Dmitry Baryshkov, will add new driver for Qualcomm IPQ5332 USB Gen3 PHY driver.
- Praveenkumar > > Best regards, > Krzysztof >
| |