Messages in this thread | | | Date | Thu, 31 Aug 2023 14:03:18 +0200 | Subject | Re: [PATCH v2 1/2] dt-bindings: i2c: Add custom properties for MAX7357/MAX7358 | From | Krzysztof Kozlowski <> |
| |
On 31/08/2023 12:15, Naresh Solanki wrote: > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > Both chips have a configuration register to enable additional > features. These features aren't enabled by default & its up to > board designer to enable the same. > > Add booleans for: > - maxim,isolate-stuck-channel > - maxim,send-flush-out-sequence > - maxim,preconnection-wiggle-test-enable > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
Subject: still did not improve. You waited exactly 30 minutes for my feedback after sending your response.
> --- > Changes in V2: > - Update properties. > --- > .../bindings/i2c/i2c-mux-pca954x.yaml | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > index 2d7bb998b0e9..fa73eadfdf7b 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > @@ -71,6 +71,23 @@ properties: > description: A voltage regulator supplying power to the chip. On PCA9846 > the regulator supplies power to VDD2 (core logic) and optionally to VDD1. > > + maxim,isolate-stuck-channel: > + type: boolean > + description: Allows to use non faulty channels while a stuck channel is > + isolated from the upstream bus. If not set all channels are isolated from > + the upstream bus until the fault is cleared.
Nothing improved here. As I said, please provide arguments or drop this property.
> + > + maxim,send-flush-out-sequence: > + type: boolean > + description: Send a flush-out sequence to stuck auxiliary buses > + automatically after a stuck channel is being detected.
Ditto
> + > + maxim,preconnection-wiggle-test-enable: > + type: boolean > + description: Send a STOP condition to the auxiliary buses when the switch > + register activates a channel to detect a stuck high fault. On fault the > + channel is isolated from the upstream bus.
Ditto
Best regards, Krzysztof
| |