lkml.org 
[lkml]   [2023]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Possible cut'n'paste error in linux-6.5/drivers/thunderbolt/tmu.c
Hi,

On Thu, Aug 31, 2023 at 11:02:58AM +0000, David Binderman wrote:
> Hello there,
>
> I just tried out static analyser cppcheck on linux-6.5. It said:
>
> linux-6.5/drivers/thunderbolt/tmu.c:385:50: style: Expression is always false because 'else if' condition matches previous condition at line 383. [multiCondition]
>
> Source code is
>
> if (tmu_rates[TB_SWITCH_TMU_MODE_LOWRES] == rate)
> sw->tmu.mode = TB_SWITCH_TMU_MODE_LOWRES;
> else if (tmu_rates[TB_SWITCH_TMU_MODE_LOWRES] == rate)
> sw->tmu.mode = TB_SWITCH_TMU_MODE_HIFI_UNI;
>

Thanks for the report. Indeed, this should be

else if (tmu_rates[TB_SWITCH_TMU_MODE_HIFI_UNI] == rate)
sw->tmu.mode = TB_SWITCH_TMU_MODE_HIFI_UNI;

I will fix it up and send out after v6.6-rc1 is released.

\
 
 \ /
  Last update: 2023-08-31 13:17    [W:2.403 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site