Messages in this thread | | | Date | Thu, 31 Aug 2023 13:32:05 +0800 | Subject | Re: [PATCH v2 3/4] arm64: dts: mediatek: mt6360: add PMIC MT6360 related nodes | From | Macpaul Lin <> |
| |
On 8/30/23 19:20, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On 30/08/2023 13:15, Macpaul Lin wrote: >> + >> +led { >> +compatible = "mediatek,mt6360-led"; >> +}; >> + >> +regulator { >> +compatible = "mediatek,mt6360-regulator"; >> +LDO_VIN3-supply = <&mt6360_emi_vddq_buck2_reg>; >> + >> +mt6360_emi_vdd2_buck1_reg: buck1-emi-vdd2 { > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ <https://urldefense.com/v3/__https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/__;!!CTRNKA9wMg0ARbw!nP-6nVffZXG2NCdjcl06my5g9HAohnT-GF-EIGrMWpegsBvwmqgOjfVQba5Ub13z_AWAJwGOlsQ3DSIWGo0ojHlPvDZ74WE$> > for instructions). > > Best regards, > Krzysztof > >
Thanks for the review. Since next patch 4/4 of the patch set to modify mt6360 nodes in mt8195-demo.dts is no longer required, please drop this patch, too.
Thanks Macpaul Lin
| |