Messages in this thread | | | Date | Thu, 31 Aug 2023 10:45:50 +0200 | Subject | Re: [PATCH v2 1/3] vfio: trivially use __aligned_u64 for ioctl structs | From | Philippe Mathieu-Daudé <> |
| |
On 29/8/23 20:27, Stefan Hajnoczi wrote: > u64 alignment behaves differently depending on the architecture and so > <uapi/linux/types.h> offers __aligned_u64 to achieve consistent behavior > in kernel<->userspace ABIs. > > There are structs in <uapi/linux/vfio.h> that can trivially be updated > to __aligned_u64 because the struct sizes are multiples of 8 bytes. > There is no change in memory layout on any CPU architecture and > therefore this change is safe. > > The commits that follow this one handle the trickier cases where > explanation about ABI breakage is necessary. > > Suggested-by: Jason Gunthorpe <jgg@nvidia.com> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > include/uapi/linux/vfio.h | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| |