Messages in this thread | | | Date | Thu, 31 Aug 2023 08:13:10 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C) |
| |
On Thu, Aug 31, 2023 at 06:40:04AM +0200, Oleksij Rempel wrote: > Hi Lukasz, > > On Wed, Aug 30, 2023 at 06:38:18PM +0200, Lukasz Majewski wrote: > > Hi Oleksij, > > > The implementation as you suggested seems to work :-) > > > > The ksz_get_phy_flags() - where the MICREL_NO_EEE is set is executed > > before ksz9477_config_init(). > > > > And then the eee_broken_modes are taken into account. > > > > # ethtool --show-eee lan1 > > EEE Settings for lan1: > > EEE status: disabled > > Tx LPI: 0 (us) > > Supported EEE link modes: 100baseT/Full > > 1000baseT/Full > > Advertised EEE link modes: Not reported > > Link partner advertised EEE link modes: Not reported > > > > I will prepare tomorrow a proper patch. > > can you please by the way remove this line: > https://elixir.bootlin.com/linux/v6.5/source/drivers/net/phy/micrel.c#L1803 > > it is obsolet by eee_broken_modes.
... and if possible verify on the link partner side that indeed no EEE modes are being advertised by the Micrel device.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
| |