lkml.org 
[lkml]   [2023]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] firmware: arm_scmi: Fix NULL pointer dereference in mailbox_clear_channel
On Wed, Aug 30, 2023 at 01:07:47AM +0800, Qiujun Huang wrote:
> There is a race between the failure of probe and rx_callback (due to a
> delayed response).
>
> scmi_probe
> scmi_acquire_protocal
> do_xfer
> timeout
> mailbox_chan_free
> <--- delay response
> rx_callback
> mbox_free_channel
> cinfo->transport_info = NULL
> mailbox_clear_channel
> dereference cinfo->transport_info

It is always good to provide the kernel stacktrace which you get when a
NULL pointer is dereference. It helps for review and also to document it.

--
Regards,
Sudeep

\
 
 \ /
  Last update: 2023-08-30 21:30    [W:0.066 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site