Messages in this thread | | | From | Andreas Schwab <> | Subject | Re: [PATCH] riscv: kexec: Cleanup riscv_kexec_relocate | Date | Wed, 30 Aug 2023 09:24:33 +0200 |
| |
On Aug 30 2023, Song Shuai wrote:
> @@ -52,21 +42,27 @@ SYM_CODE_START(riscv_kexec_relocate) > * the start of the loop below so that we jump there in > * any case. > */ > - la s8, 1f > - sub s8, s8, s7 > - csrw CSR_STVEC, s8 > + la s6, 1f > + sub s6, s6, s4 > + csrw CSR_STVEC, s6 > + > + /* > + * With C-extension, here we get 42 Bytes and the next > + * .align directive would pad zeros here up to 44 Bytes. > + * So manually put a nop here to avoid zeros padding. > + */ > + nop > > /* Process entries in a loop */ > .align 2
While you are at it, I'd suggest being explicit about .palign vs. .balign.
-- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
| |