Messages in this thread | | | Date | Wed, 30 Aug 2023 15:40:10 +0200 | From | Maciej Wieczór-Retman <> | Subject | Re: [PATCH 6/6] selftests/kvm: Replace attribute with macro |
| |
On 2023-08-30 at 15:22:57 +0300, Ilpo Järvinen wrote: >On Mon, 28 Aug 2023, Wieczor-Retman, Maciej wrote: > >> The __printf() macro is used in many tools in the linux kernel to >> validate the format specifiers in functions that use printf. Some >> selftests use it without putting it in a macro definition and some tests >> import the kselftests.h header. > >"Some" and yet this only converts one? Please be more precise in the >wording.
Okay, I'll mention them by subsystem.
>> Use __printf() attribute instead of the full attribute since the macro >> is inside kselftests.h and the header is already imported. > >IMO, this would be enough: > >Use __printf() from kselftests.h instead of the full attribute.
Fair enough, I'll change the paragraph to that.
>Was there a reason why you didn't convert mm/pkey-helpers.h one?
Sorry, must have just missed it somehow. Thank you for pointing it out.
-- Kind regards Maciej Wieczór-Retman
| |