Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH v4 09/10] iommu: Make iommu_queue_iopf() more generic | Date | Wed, 30 Aug 2023 07:34:49 +0000 |
| |
> From: Baolu Lu <baolu.lu@linux.intel.com> > Sent: Saturday, August 26, 2023 3:32 PM > > On 8/25/23 4:17 PM, Tian, Kevin wrote: > >> From: Lu Baolu <baolu.lu@linux.intel.com> > >> Sent: Friday, August 25, 2023 10:30 AM > >> > >> +int iommu_sva_handle_iopf(struct iopf_group *group) > >> +{ > >> + struct iommu_fault_param *fault_param = group->dev->iommu- > >>> fault_param; > >> + > >> + INIT_WORK(&group->work, iopf_handler); > >> + if (!queue_work(fault_param->queue->wq, &group->work)) > >> + return -EBUSY; > >> + > >> + return 0; > >> +} > > > > this function is generic so the name should not tie to 'sva'. > > Currently only sva uses it. It's fine to make it generic later when any > new use comes. Does it work to you? >
It's fine given you moved this function to sva.c in next patch.
| |