lkml.org 
[lkml]   [2023]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/7] ASoC: cs35l45: Analog PCM Volume and Amplifier Mode controls
From

On 8/28/23 14:39, Mark Brown wrote:
> On Mon, Aug 28, 2023 at 12:05:22PM -0500, Vlad Karpovich wrote:
>
>> +static int cs35l45_amplifier_mode_put(struct snd_kcontrol *kcontrol,
>> + struct snd_ctl_elem_value *ucontrol)
>> +{
>> + snd_soc_component_enable_pin_unlocked(component, "SPK");
>> + snd_soc_dapm_sync_unlocked(dapm);
>> + snd_soc_dapm_mutex_unlock(dapm);
>> + cs35l45->amplifier_mode = ucontrol->value.integer.value[0];
>> + return 0;
>> +}
> This should return 1 on change (I did see that there's some code which
> generates notifications but it would still be better to flag changes
> here, it makes review a lot easier).
Thanks. I will update patch.

\
 
 \ /
  Last update: 2023-08-30 21:09    [W:0.065 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site