Messages in this thread | | | Date | Wed, 30 Aug 2023 13:34:21 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v1] EDAC/bluefield_edac: Use ARM SMC for EMI access |
| |
On Wed, Aug 30, 2023 at 06:56:14AM -0400, Shravan Kumar Ramani wrote: > Add secure read/write calls (arm_smccc_smc) to bluefield_edac. > The ACPI table entry decides whether SMC is need for accessing
SMC? Self-Modifying Code?
> the registers in the External Memory Interface block. If not, > the registers may be mapped and accessed directly.
I'm sure there's a human readable explanation for the above.
> v0 -> v1 > Updated commit message
I still have no clue what those secure calls are.
I'm sure there's some ARM documentation which you use in order to explain why those are needed.
> +static int edac_readl(void __iomem *addr, uint32_t *result,
No "edac_" previxes to driver-local functions. They belong to the EDAC subsystem.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |