Messages in this thread | | | From | Jerry Snitselaar <> | Subject | Re: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs | Date | Wed, 30 Aug 2023 11:25:45 -0700 |
| |
> On Aug 29, 2023, at 12:03 PM, Jerry Snitselaar <jsnitsel@redhat.com> wrote: > > On Wed, Aug 23, 2023 at 02:15:10AM +0300, Jarkko Sakkinen wrote: >> The vendor check introduced by commit 554b841d4703 ("tpm: Disable RNG for >> all AMD fTPMs") doesn't work properly on a number of Intel fTPMs. On the >> reported systems the TPM doesn't reply at bootup and returns back the >> command code. This makes the TPM fail probe. >> >> Since only Microsoft Pluton is the only known combination of AMD CPU and >> fTPM from other vendor, disable hwrng otherwise. In order to make sysadmin >> aware of this, print also info message to the klog. >> >> Cc: stable@vger.kernel.org >> Fixes: 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs") >> Reported-by: Todd Brandt <todd.e.brandt@intel.com> >> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217804 >> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> >> --- >> v3: >> * Forgot to amend config flags. >> v2: >> * CONFIG_X86 >> * Removed "Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>" >> * Removed "Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>" >> --- >> drivers/char/tpm/tpm_crb.c | 33 ++++++++------------------------- >> 1 file changed, 8 insertions(+), 25 deletions(-) >> > > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
It looks like the Fedora folks are getting more reports of the issue.
| |