Messages in this thread | | | Date | Wed, 30 Aug 2023 12:08:17 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C) |
| |
On Wed, Aug 30, 2023 at 11:21:19AM +0200, Lukasz Majewski wrote: > + /* KSZ9477 Errata DS80000754C > + * > + * Module 4: Energy Efficient Ethernet (EEE) feature select must be > + * manually disabled > + * The EEE feature is enabled by default, but it is not fully > + * operational. It must be manually disabled through register > + * controls. If not disabled, the PHY ports can auto-negotiate > + * to enable EEE, and this feature can cause link drops when linked > + * to another device supporting EEE. > + * > + * Although, the KSZ9477 MMD register > + * (MMD_DEVICE_ID_EEE_ADV.MMD_EEE_ADV) advertise that EEE is > + * operational one needs to manualy clear them to follow the chip > + * errata. > + */ > + linkmode_and(phydev->supported_eee, phydev->supported, zero);
Hi,
I'm wondering whether you had a reason to write the above, rather than use the simpler:
linkmode_zero(phydev->supported_eee);
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
| |