Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Thu, 3 Aug 2023 15:48:58 +0200 | Subject | Re: [PATCH] gpio: vx855: remove unneeded call to platform_set_drvdata() |
| |
On Tue, Aug 1, 2023 at 10:45 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/gpio/gpio-vx855.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpio/gpio-vx855.c b/drivers/gpio/gpio-vx855.c > index 69713fd5485b..8fd6c3913d69 100644 > --- a/drivers/gpio/gpio-vx855.c > +++ b/drivers/gpio/gpio-vx855.c > @@ -240,8 +240,6 @@ static int vx855gpio_probe(struct platform_device *pdev) > if (!vg) > return -ENOMEM; > > - platform_set_drvdata(pdev, vg); > - > dev_info(&pdev->dev, "found VX855 GPIO controller\n"); > vg->io_gpi = res_gpi->start; > vg->io_gpo = res_gpo->start; > -- > 2.34.1 >
Applied, thanks!
Bart
| |