Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Thu, 3 Aug 2023 15:43:36 +0200 | Subject | Re: [PATCH] gpio: sch: remove unneeded call to platform_set_drvdata() |
| |
On Tue, Aug 1, 2023 at 9:28 AM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/gpio/gpio-sch.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c > index 8a83f7bf4382..e48392074e4b 100644 > --- a/drivers/gpio/gpio-sch.c > +++ b/drivers/gpio/gpio-sch.c > @@ -380,8 +380,6 @@ static int sch_gpio_probe(struct platform_device *pdev) > return -ENODEV; > } > > - platform_set_drvdata(pdev, sch); > - > girq = &sch->chip.irq; > gpio_irq_chip_set_chip(girq, &sch_irqchip); > girq->num_parents = 0; > -- > 2.34.1 >
Applied, thanks!
Bart
| |