Messages in this thread Patch in this message | | | From | Tomi Valkeinen <> | Date | Thu, 03 Aug 2023 15:15:47 +0300 | Subject | [PATCH v2 3/3] media: i2c: ds90ub960: Fix PLL config for 1200 MHz CSI rate |
| |
smatch reports:
drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'.
This is caused by 'pll_div' not being set for 1200 MHz CSI rate. Set the 'pll_div' correctly.
Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver") Reported-by: Hans Verkuil <hverkuil@xs4all.nl> Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/ Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- drivers/media/i2c/ds90ub960.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index 4833b39b9178..4ab45e326d80 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -1763,6 +1763,7 @@ static int ub960_init_tx_ports(struct ub960_data *priv) break; case MHZ(1200): speed_select = 1; + pll_div = 0x18; break; case MHZ(800): speed_select = 2; -- 2.34.1
| |