Messages in this thread | | | Subject | Re: [Intel-wired-lan] [PATCH v3 net-next 00/10] Improve the taprio qdisc's relationship with its children | From | Paolo Abeni <> | Date | Thu, 03 Aug 2023 12:04:32 +0200 |
| |
Hi,
On Tue, 2023-08-01 at 21:24 +0300, Vladimir Oltean wrote: > Changes in v3: > Fix ptp_mock compilation as module, fix small mistakes in selftests. > > Changes in v2: > It was requested to add test cases for the taprio software and offload modes. > Those are patches 08 and 09. > > That implies adding taprio offload support to netdevsim, which is patch 07. > > In turn, that implies adding a PHC driver for netdevsim, which is patch 06. > > v1 at: > https://lore.kernel.org/lkml/20230531173928.1942027-1-vladimir.oltean@nxp.com/ > > Original message: > > Prompted by Vinicius' request to consolidate some child Qdisc > dereferences in taprio: > https://lore.kernel.org/netdev/87edmxv7x2.fsf@intel.com/ > > I remembered that I had left some unfinished work in this Qdisc, namely > commit af7b29b1deaa ("Revert "net/sched: taprio: make qdisc_leaf() see > the per-netdev-queue pfifo child qdiscs""). > > This patch set represents another stab at, essentially, what's in the > title. Not only does taprio not properly detect when it's grafted as a > non-root qdisc, but it also returns incorrect per-class stats. > Eventually, Vinicius' request is addressed too, although in a different > form than the one he requested (which was purely cosmetic). > > Review from people more experienced with Qdiscs than me would be > appreciated. I tried my best to explain what I consider to be problems. > I am deliberately targeting net-next because the changes are too > invasive for net - they were reverted from stable once already.
The series LGTM, modulo the minor comments from Kurt on patch 6/10. I agree they can be handled with follow-up patches.
Keeping it a little longer on PW: it would be great if someone from the tc crew could have a look!
Thanks!
Paolo
| |