Messages in this thread | | | Date | Thu, 3 Aug 2023 11:36:45 +0200 | Subject | Re: [PATCH v4 1/2] mm: Remove kmem_valid_obj() | From | Vlastimil Babka <> |
| |
On 8/2/23 15:09, thunder.leizhen@huaweicloud.com wrote: > From: Zhen Lei <thunder.leizhen@huawei.com> > > Function kmem_dump_obj() will splat if passed a pointer to a non-slab > object. So no one will call it directly. It is always necessary to call > kmem_valid_obj() first to determine whether the passed pointer to a > valid slab object. Then merging kmem_valid_obj() into kmem_dump_obj() > will make the code more concise. So convert kmem_dump_obj() to work the > same way as vmalloc_dump_obj(). After this, no one calls kmem_valid_obj() > anymore, and it can be safely removed. > > Suggested-by: Matthew Wilcox <willy@infradead.org> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
No problem if this goes through rcu tree due to patch 2/2.
| |