Messages in this thread | | | Date | Thu, 3 Aug 2023 07:20:17 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH v3] tty: vt: Remove some repetitive initialization |
| |
On 02. 08. 23, 4:20, oushixiong wrote: > Members vc_col, vc_rows and vc_size_row of the struct vc_data have been > initialized in visual_init(), so it no longer to initialized them again > in vc_init().
The patch looks correct to me. The duplicated code comes from some 1.x era.
The part after the comma should be something like: "so it is no longer needed to initialize them in vc_init() again."
> Signed-off-by: oushixiong <oushixiong@kylinos.cn>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
thanks, -- js suse labs
| |