Messages in this thread | | | Date | Thu, 3 Aug 2023 09:50:03 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/1] serial: core: Fix serial_base_match() after fixing controller port name |
| |
On Thu, Aug 03, 2023 at 10:10:32AM +0300, Tony Lindgren wrote: > While fixing DEVNAME to be more usable, I broke serial_base_match() as the > ctrl and port prefix for device names seemed unnecessary. > > The prefixes are still needed by serial_base_match() to probe the serial > base controller port, and serial tx is now broken. > > Let's fix the issue by checking against dev->type and drv->name instead > of the prefixes that are no longer in the DEVNAME. > > Fixes: 1ef2c2df1199 ("serial: core: Fix serial core controller port name to show controller id") > Reported-by: kernel test robot <oliver.sang@intel.com> > Closes: https://lore.kernel.org/oe-lkp/202308021529.35b3ad6c-oliver.sang@intel.com > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > > Changes since v1: > - Leave out magic numbers and use str_has_prefix() as suggested by Andy > and Greg > > - Improve patch description and add a link for Closes tag as suggested > by Jiri > > - Check the name against device_type name since we have it and leave > out the changes to try to define names in the header because of the > issues noted by Jiri > > - Leave out Tested-by from Mark and Anders as the patch changed
Thanks for this, now queued up.
greg k-h
| |