Messages in this thread | | | Date | Thu, 03 Aug 2023 22:20:16 -0400 | From | Paul Moore <> | Subject | Re: [PATCH v2 1/9] selinux: avoid implicit conversions in avtab code |
| |
On Jul 28, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com> wrote: > > Return u32 from avtab_hash() instead of int, since the hashing is done > on u32 and the result is used as an index on the hash array. > > Use the type of the limit in for loops. > > Avoid signed to unsigned conversion of multiplication result in > avtab_hash_eval(). > > Use unsigned loop iterator for index operations, to avoid sign > extension. > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > v2: avoid declarations in init-clauses of for loops > --- > security/selinux/ss/avtab.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/security/selinux/ss/avtab.c b/security/selinux/ss/avtab.c > index 32f92da00b0e..8a508018e696 100644 > --- a/security/selinux/ss/avtab.c > +++ b/security/selinux/ss/avtab.c
...
> @@ -324,7 +324,8 @@ int avtab_alloc_dup(struct avtab *new, const struct avtab *orig) > > void avtab_hash_eval(struct avtab *h, const char *tag) > { > - int i, chain_len, slots_used, max_chain_len; > + u32 i; > + unsigned int chain_len, slots_used, max_chain_len;
Since the total number of elements in the hash table and the number of hash buckets/slots are both u32, it seems reasonable to me that we would also want the 'chain_len', 'slots_used', and 'max_chain_len' variables as u32, yes?
> unsigned long long chain2_len_sum; > struct avtab_node *cur; >
-- paul-moore.com
| |