lkml.org 
[lkml]   [2023]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] dmaengine: ste_dma40: Add missing IRQ check in d40_probe
From
Ping.

On 2023/7/24 22:41, Ruan Jinjie wrote:
> From: ruanjinjie <ruanjinjie@huawei.com>
>
> Check for the return value of platform_get_irq(): if no interrupt
> is specified, it wouldn't make sense to call request_irq().
>
> Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/dma/ste_dma40.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 825001bde42c..89e82508c133 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -3590,6 +3590,10 @@ static int __init d40_probe(struct platform_device *pdev)
> spin_lock_init(&base->lcla_pool.lock);
>
> base->irq = platform_get_irq(pdev, 0);
> + if (base->irq < 0) {
> + ret = base->irq;
> + goto destroy_cache;
> + }
>
> ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base);
> if (ret) {

\
 
 \ /
  Last update: 2023-08-04 03:14    [W:0.035 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site