Messages in this thread | | | Date | Thu, 3 Aug 2023 17:54:59 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v1] perf stat: Don't display zero tool counts |
| |
Em Tue, Aug 01, 2023 at 01:54:52PM -0700, Ian Rogers escreveu: > Skip zero counts for tool events. > > Reported-by: Andi Kleen <ak@linux.intel.com>
Andi,
Have you tested this? Can we please have your Tested-by?
- Arnaldo:1
> Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/util/stat-display.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 7329b3340f88..d45d5dcb0e2b 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -931,6 +931,11 @@ static bool should_skip_zero_counter(struct perf_stat_config *config, > */ > if (config->aggr_mode == AGGR_THREAD && config->system_wide) > return true; > + > + /* Tool events have the software PMU but are only gathered on 1. */ > + if (evsel__is_tool(counter)) > + return true; > + > /* > * Skip value 0 when it's an uncore event and the given aggr id > * does not belong to the PMU cpumask. > -- > 2.41.0.585.gd2178a4bd4-goog >
--
- Arnaldo
| |