Messages in this thread | | | Date | Thu, 3 Aug 2023 19:22:18 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM |
| |
On Thu, Aug 03, 2023 at 11:09:43AM -0700, Randy Dunlap wrote: > On 8/3/23 04:27, Mark Brown wrote: > > On Wed, Aug 02, 2023 at 07:59:41PM -0700, Randy Dunlap wrote:
> >> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select > >> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, > >> so the 2 former symbols should also depend on PPC_BESTCOMM since > >> "select" does not follow any dependency chains.
> > Take a hint, it's not clear that the patch is tasteful.
> Thank you for replying. I'll drop it and just report the build errors.
To be clear I generally don't give you review comments because in the past I grew so frustrated with having them and their escalations ignored that it seemed better to just not start. If the patch seems fine I generally apply it, usually you just don't resend patches so that works. [unhandled content-type:application/pgp-signature] | |