Messages in this thread | | | Date | Thu, 3 Aug 2023 10:01:10 -0700 | Subject | Re: [PATCH] block/mq-deadline: use correct way to throttling write requests | From | Bart Van Assche <> |
| |
On 8/3/23 04:12, Zhiguo Niu wrote: > diff --git a/block/mq-deadline.c b/block/mq-deadline.c > index 5839a027e0f0..7e043d4a78f8 100644 > --- a/block/mq-deadline.c > +++ b/block/mq-deadline.c > @@ -620,8 +620,9 @@ static void dd_depth_updated(struct blk_mq_hw_ctx *hctx) > struct request_queue *q = hctx->queue; > struct deadline_data *dd = q->elevator->elevator_data; > struct blk_mq_tags *tags = hctx->sched_tags; > + unsigned int shift = tags->bitmap_tags.sb.shift; > > - dd->async_depth = max(1UL, 3 * q->nr_requests / 4); > + dd->async_depth = max(1U, 3 * (1U << shift) / 4); > > sbitmap_queue_min_shallow_depth(&tags->bitmap_tags, dd->async_depth); > }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |