Messages in this thread | | | Date | Thu, 3 Aug 2023 09:56:34 +0300 | From | Tony Lindgren <> | Subject | Re: [PATCH] serial: core: Fix serial_base_match() after fixing controller port name |
| |
* Jiri Slaby <jirislaby@kernel.org> [230803 05:13]: > On 02. 08. 23, 13:48, Tony Lindgren wrote: > > @@ -6,6 +6,9 @@ > > * Author: Tony Lindgren <tony@atomide.com> > > */ > > +#define SERIAL_BASE_CTRL_NAME "ctrl" > > +#define SERIAL_BASE_PORT_NAME "port" > > Could you make those char[] instead? The compiler/linker will hopefully > (will it?) de-dup the occurrences, but the arrays would look cleaner and > safer from this POV.
Heh yeah so we already have that in serial_ctrl_type.name and serial_port_type.name so let's just check against those for a minimal fix.
Regards,
Tony
| |