Messages in this thread | | | Date | Tue, 29 Aug 2023 08:37:31 +0200 | Subject | Re: [PATCH v3 2/6] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG | From | Krzysztof Kozlowski <> |
| |
On 28/08/2023 10:04, Neil Armstrong wrote: > It has been reported at [1] the RNG HW on SM8450 is in fact a True Random > Number Generator and no more Pseudo, document this by adding > a new qcom,trng and the corresponding SoC specific sm8450 compatible. > > [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/ > > Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com> > Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../devicetree/bindings/crypto/qcom,prng.yaml | 24 +++++++++++++++++----- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml > index bb42f4588b40..4245c9e424a3 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml > @@ -11,9 +11,13 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,prng # 8916 etc. > - - qcom,prng-ee # 8996 and later using EE > + oneOf: > + - enum: > + - qcom,prng # 8916 etc. > + - qcom,prng-ee # 8996 and later using EE > + - items: > + - const: qcom,sm8450-trng
Make it already an enum, so you won't have to change same lines twice.
Best regards, Krzysztof
| |