lkml.org 
[lkml]   [2023]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH][next][V2] jfs: remove redundant initialization to pointer ip
From
On 8/18/23 10:02AM, Colin Ian King wrote:
> The pointer ip is being initialized with a value that is never read, it
> is being re-assigned later on. The assignment is redundant and can be
> removed. Cleans up clang scan warning:
>
> fs/jfs/namei.c:886:16: warning: Value stored to 'ip' during its
> initialization is never read [deadcode.DeadStores]

Looks good. Applied.

>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>
> V2: fix commit message "uninitialized" -> "initialized"
>
> ---
> fs/jfs/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
> index 029d47065600..57d7a4300210 100644
> --- a/fs/jfs/namei.c
> +++ b/fs/jfs/namei.c
> @@ -883,7 +883,7 @@ static int jfs_symlink(struct mnt_idmap *idmap, struct inode *dip,
> struct component_name dname;
> u32 ssize; /* source pathname size */
> struct btstack btstack;
> - struct inode *ip = d_inode(dentry);
> + struct inode *ip;
> s64 xlen = 0;
> int bmask = 0, xsize;
> s64 xaddr;

\
 
 \ /
  Last update: 2023-08-29 19:25    [W:0.084 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site