Messages in this thread | | | Date | Tue, 29 Aug 2023 18:18:07 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2] ASoC: wm8580: Simplify probe() |
| |
On Mon, Aug 28, 2023 at 06:40:19PM +0100, Biju Das wrote: > Simplify probe() by replacing of_match_device->i2c_get_match_data() and > extend matching support for ID table. > > While at it, remove comma in the terminator entry and simplify probe() > by replacing dev_err->dev_err_probe().
dev_err() --> dev_err_probe()
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> -static const struct of_device_id wm8580_of_match[] = { > - { .compatible = "wlf,wm8580", .data = &wm8580_data }, > - { .compatible = "wlf,wm8581", .data = &wm8581_data }, > - { }, > -}; > -MODULE_DEVICE_TABLE(of, wm8580_of_match);
This doesn't change anything functional, please do it in a separate change.
-- With Best Regards, Andy Shevchenko
| |