Messages in this thread | | | From | Biju Das <> | Subject | RE: [PATCH v2] mfd: max77541: Simplify probe() | Date | Tue, 29 Aug 2023 14:58:20 +0000 |
| |
Hi Andy Shevchenko,
> Subject: Re: [PATCH v2] mfd: max77541: Simplify probe() > > On Mon, Aug 28, 2023 at 04:38:05PM +0100, Biju Das wrote: > > Simplify probe() by replacing device_get_match_data() and ID lookup > > for retrieving match data by i2c_get_match_data(). > > ... > > > While at it, drop leading commas from OF table. > > Sure? > > ... > > > static const struct of_device_id max77541_of_id[] = { > > - { > > - .compatible = "adi,max77540", > > - .data = (void *)MAX77540, > > - }, > > - { > > - .compatible = "adi,max77541", > > - .data = (void *)MAX77541, > > - }, > > + { .compatible = "adi,max77540", .data = (void *)MAX77540 }, > > + { .compatible = "adi,max77541", .data = (void *)MAX77541 }, > > { } > > }; > > Seems to me an unneeded churn as nothing has been changed here (except > commas and indentation). If any, it should be a separate change.
See there is a comma after every .data, that is leading commas right?
Cheers, Biju
| |