lkml.org 
[lkml]   [2023]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: linux-next: Tree for Aug 28 (drivers/platform/x86/mlx-platform.c)
Date


> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Monday, 28 August 2023 23:36
> To: Stephen Rothwell <sfr@canb.auug.org.au>; Linux Next Mailing List <linux-
> next@vger.kernel.org>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; open list:X86
> PLATFORM DRIVERS <platform-driver-x86@vger.kernel.org>; Vadim Pasternak
> <vadimp@nvidia.com>; Hans de Goede <hdegoede@redhat.com>; Mark
> Gross <markgross@kernel.org>; PCI <linux-pci@vger.kernel.org>
> Subject: Re: linux-next: Tree for Aug 28 (drivers/platform/x86/mlx-platform.c)
>
>
>
> On 8/27/23 22:02, Stephen Rothwell wrote:
> > Hi all,
> >
> > Please do *not* include material destined for v6.7 in your linux-next
> > included branches until *after* v6.6-rc1 has been released. Also, do
> > *not* rebase you linu-next included branches onto v6.5.
> >
> > Changes since 20230825:
> >
>
> on i386:
> CONFIG_ACPI=y
> CONFIG_ISA=y
> # CONFIG_PCI is not set
>
> ../drivers/platform/x86/mlx-platform.c: In function
> 'mlxplat_pci_fpga_device_init':
> ../drivers/platform/x86/mlx-platform.c:6204:15: error: implicit declaration of
> function 'pci_request_region'; did you mean 'pci_request_regions'? [-
> Werror=implicit-function-declaration]
> 6204 | err = pci_request_region(pci_dev, 0, res_name);
> | ^~~~~~~~~~~~~~~~~~
> | pci_request_regions
>
> Should MLX_PLATFORM depend on PCI?
>
> or do we need a stub for pci_request_region()?

Thanks, Randy.

Need to add: 'depend on PCI'.

I will send a patch.

>
> --
> ~Randy
\
 
 \ /
  Last update: 2023-08-29 07:40    [W:0.103 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site