Messages in this thread | | | Date | Tue, 29 Aug 2023 15:04:52 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 03/10] cpuidle: Report illegal tick stopped while polling |
| |
On Fri, Aug 11, 2023 at 07:37:55PM +0200, Rafael J. Wysocki wrote: > On Fri, Aug 11, 2023 at 7:01 PM Frederic Weisbecker <frederic@kernel.org> wrote: > > > > poll_idle() can't be called while the tick is stopped because it enables > > interrupts and only polls on TIF_NEED_RESCHED, which doesn't tell if an > > interrupt queues a timer that would require a tick re-programming. > > > > There is no point anyway to poll with the tick stopped so add a check > > to make sure it never happens. > > I'd rather update governors so they never use polling states when the > tick has been stopped and then add the WARN_ON().
Sounds good, let's put this one aside.
In the meantime feel free to pick up those you acked and see fit in your queue.
Thanks!
| |