Messages in this thread | | | Date | Tue, 29 Aug 2023 15:00:04 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH RESEND] i2c: at91: Use dev_err_probe() instead of dev_err() |
| |
BTW...
> > Change > > if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); } > > into > > return dev_err_probe() > > > > Also, return the correct error instead of hardcoding -ENODEV > > This change has also the advantage of handling the -EPROBE_DEFER situation. > > > > Signed-off-by: Yann Sionneau <yann@sionneau.net> > > Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
for the next time, please, if you make changes to the patch, starting from the commit title, commit message, patch body, you need to increment the versioning and note the change in the changelog.
Use resend only if the patch is taken and sent as it is without any change, anywhere.
This should have been [PATCH v2].
Andi
| |