Messages in this thread | | | From | Huacai Chen <> | Date | Tue, 29 Aug 2023 12:11:42 +0800 | Subject | Re: [PATCH 2/2] Loongarch: KGDB: fix build when CPU_HAS_LBT not set |
| |
Hi, Randy,
On Tue, Aug 29, 2023 at 8:23 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > Fix build errors when CONFIG_CPU_HAS_LBT is not set: > > loongarch64-linux-ld: arch/loongarch/kernel/kgdb.o: in function `dbg_get_reg': > arch/loongarch/kernel/kgdb.c:154:(.text+0xc7c): undefined reference to `_save_lbt' > loongarch64-linux-ld: arch/loongarch/kernel/kgdb.o: in function `dbg_set_reg': > arch/loongarch/kernel/kgdb.c:229:(.text+0x13a4): undefined reference to `_restore_lbt' Thank you for your patch, this has been fixed in today's linux-next.
Huacai > > Fixes: 8968eb010689 ("LoongArch: Add basic KGDB & KDB support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Qing Zhang <zhangqing@loongson.cn> > Cc: Hui Li <lihui@loongson.cn> > Cc: Binbin Zhou <zhoubinbin@loongson.cn> > Cc: Huacai Chen <chenhuacai@kernel.org> > Cc: WANG Xuerui <kernel@xen0n.name> > Cc: loongarch@lists.linux.dev > --- > arch/loongarch/kernel/kgdb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff -- a/arch/loongarch/kernel/kgdb.c b/arch/loongarch/kernel/kgdb.c > --- a/arch/loongarch/kernel/kgdb.c > +++ b/arch/loongarch/kernel/kgdb.c > @@ -150,7 +150,8 @@ char *dbg_get_reg(int regno, void *mem, > } > > /* Handle LBT registers */ > - if ((regs->csr_euen & CSR_EUEN_LBTEN)) { > + if (IS_ENABLED(CONFIG_CPU_HAS_LBT) && > + (regs->csr_euen & CSR_EUEN_LBTEN)) { > _save_lbt(¤t->thread.lbt); > > switch (regno) { > @@ -211,7 +212,8 @@ int dbg_set_reg(int regno, void *mem, st > } > > /* Handle LBT registers */ > - if ((regs->csr_euen & CSR_EUEN_LBTEN)) { > + if (IS_ENABLED(CONFIG_CPU_HAS_LBT) && > + (regs->csr_euen & CSR_EUEN_LBTEN)) { > switch (regno) { > case DBG_FTOP: /* Process the ftop */ > memcpy((char *)¤t->thread.fpu.ftop, mem, reg_size);
| |