lkml.org 
[lkml]   [2023]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v10 1/4] phy: qcom: m31: Fix indentation issues
From
On 29/08/2023 11:37, Varadarajan Narayanan wrote:
> Fix incorrect indentation
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v10:
> Restore register success print per Dmitry's comment
> v9:
> Fix line break alignment
> Remove register success print
> v8 version of the driver has been picked up for merge.
> (https://lore.kernel.org/linux-arm-msm/169226613917.81413.1200008047604336868.b4-ty@kernel.org/)
> v8:
> Change commit subject and message per review comments
> Don't include of_platform.h
> Change struct init coding style
> GENMASK -> BIT for one define
> v6:
> Kconfig:Add COMPILE_TEST and remove USB_GADGET from 'depends'
> Change 'selects' USB_PHY -> GENERIC_PHY
> Driver: Use correct headers
> const int -> unsigned int for 'nregs' in private data
> Use generic names for clk, phy in m31 phy structure
> Init register details directly instead of using macro
> Use dev_err_probe in the error paths of driver probe
> v5:
> Kconfig and Makefile:- place snippet according to sorted order
> Use generic phy instead of usb-phy
> Use ARRAY_SIZE for reg init instead of blank last entry
> Fix copyright year
>
> v4:
> Remove unused enum
> Error handling for devm_clk_get
> v1:
> Combine driver, makefile and kconfig into 1 patch
> Remove 'qscratch' region and its usage. The controller driver takes care
> of those settings
> Use compatible/data to handle ipq5332 init
> Drop the default case
> Get resources by index instead of name as there is only one resource
> Add clock
> Fix review comments in the driver
> ---
> drivers/phy/qualcomm/phy-qcom-m31.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2023-08-29 11:34    [W:0.043 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site