Messages in this thread Patch in this message | | | From | Daniel Wagner <> | Subject | [RFC v1 4/4] nvmet-discovery: do not use invalid port | Date | Tue, 29 Aug 2023 11:13:49 +0200 |
| |
The port entry binding might not be existing and thus the req->port pointer is not valid.
Reproducer: nvme/005 with active system nvmf-autoconnect systemd service.
Signed-off-by: Daniel Wagner <dwagner@suse.de> --- drivers/nvme/target/discovery.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/nvme/target/discovery.c b/drivers/nvme/target/discovery.c index 668d257fa986..fc113057cb95 100644 --- a/drivers/nvme/target/discovery.c +++ b/drivers/nvme/target/discovery.c @@ -191,6 +191,15 @@ static void nvmet_execute_disc_get_log_page(struct nvmet_req *req) goto out; } + + /* No port assigned, portentrybinding is missing */ + if (!req->port) { + req->error_loc = + offsetof(struct nvme_get_log_page_command, lpo); + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR; + goto out; + } + /* * Make sure we're passing at least a buffer of response header size. * If host provided data len is less than the header size, only the -- 2.41.0
| |