lkml.org 
[lkml]   [2023]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH next] ASoC: cs42l43: Fix missing error code in cs42l43_codec_probe()
    On Tue, Aug 29, 2023 at 12:36:35AM -0700, Harshit Mogalapalli wrote:
    > When clk_get_optional() fails, the error handling code does a 'goto
    > err_pm' with ret = 0, which is resturning success on a failure path.
    >
    > Fix this by assigning the PTR_ERR(priv->mclk) to ret variable.
    >
    > Fixes: fc918cbe874e ("ASoC: cs42l43: Add support for the cs42l43")
    > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
    > ---

    Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

    Thanks,
    Charles

    \
     
     \ /
      Last update: 2023-08-29 10:54    [W:7.209 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site