Messages in this thread | | | From | Rob Herring <> | Date | Tue, 29 Aug 2023 16:05:04 -0500 | Subject | Re: [PATCH v4 2/4] Bring in other reserved-memory files |
| |
On Tue, Aug 29, 2023 at 2:18 PM Simon Glass <sjg@chromium.org> wrote: > > Add those files from v6.5 which are already converted to yaml. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v4: > - New patch > > .../schemas/reserved-memory/framebuffer.yaml | 52 +++++++ > .../reserved-memory/google,open-dice.yaml | 46 ++++++ > .../reserved-memory/memory-region.yaml | 40 +++++ > .../nvidia,tegra210-emc-table.yaml | 31 ++++ > .../nvidia,tegra264-bpmp-shmem.yaml | 47 ++++++ > dtschema/schemas/reserved-memory/phram.yaml | 47 ++++++ > .../schemas/reserved-memory/qcom,cmd-db.yaml | 46 ++++++ > .../reserved-memory/qcom,rmtfs-mem.yaml | 55 +++++++ > dtschema/schemas/reserved-memory/ramoops.yaml | 144 ++++++++++++++++++ > .../reserved-memory/shared-dma-pool.yaml | 97 ++++++++++++ > 10 files changed, 605 insertions(+)
I don't think I want all of these in dtschema. Certainly not vendor specific ones. Generally, if it's not something we'd put in the spec, then I don't want it in dtschema. The u-boot stuff so far has been an exception.
Probably a good rule is if it has a compatible, then it doesn't go into dtschema. Though there's some exceptions already.
> create mode 100644 dtschema/schemas/reserved-memory/framebuffer.yaml
Maybe
> create mode 100644 dtschema/schemas/reserved-memory/google,open-dice.yaml
No
> create mode 100644 dtschema/schemas/reserved-memory/memory-region.yaml
Yes
> create mode 100644 dtschema/schemas/reserved-memory/nvidia,tegra210-emc-table.yaml > create mode 100644 dtschema/schemas/reserved-memory/nvidia,tegra264-bpmp-shmem.yaml
No
> create mode 100644 dtschema/schemas/reserved-memory/phram.yaml
Depends on mtd.yaml in the kernel, so no.
> create mode 100644 dtschema/schemas/reserved-memory/qcom,cmd-db.yaml > create mode 100644 dtschema/schemas/reserved-memory/qcom,rmtfs-mem.yaml
No.
> create mode 100644 dtschema/schemas/reserved-memory/ramoops.yaml
Probably not.
> create mode 100644 dtschema/schemas/reserved-memory/shared-dma-pool.yaml
Maybe.
Rob
| |