Messages in this thread | | | Date | Tue, 29 Aug 2023 15:26:13 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v5 2/2] PCI: Implement custom llseek for sysfs resource entries |
| |
On Tue, Aug 29, 2023 at 03:02:29PM -0500, Bjorn Helgaas wrote: > On Mon, Aug 28, 2023 at 12:22:54PM +0500, Valentin Sinitsyn wrote: > > On 25.08.2023 19:10, kernel test robot wrote: > > > Hi Valentine, > > > > > > kernel test robot noticed the following build warnings: > > > > > [..] > > > All warnings (new ones prefixed by >>): > > > > > > drivers/pci/pci-sysfs.c:1268:12: warning: no previous prototype for 'pci_create_resource_files' [-Wmissing-prototypes] > > > 1268 | int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; } > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > drivers/pci/pci-sysfs.c:1269:13: warning: no previous prototype for 'pci_remove_resource_files' [-Wmissing-prototypes] > > > 1269 | void __weak pci_remove_resource_files(struct pci_dev *dev) { return; } > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > drivers/pci/pci-sysfs.c:838:15: warning: 'pci_llseek_resource' defined but not used [-Wunused-function] > > > 838 | static loff_t pci_llseek_resource(struct file *filep, > > > | ^~~~~~~~~~~~~~~~~~~ > > I'm not sure if I should do anything about it: arc doesn't HAVE_* anything > > PCI-related, and pci-sysfs doesn't seem to be written with this case in > > mind. Guarding pci_llseek_resource() with an #ifdef HAVE_AT_LEAST_SOMETHING > > is trivial, but it feels more like a patch to silence a bot than a proper > > fix. > > Looks like it will require some untangling to figure out a nice fix, > but I think you *do* need to do something about it because I don't > want to add build errors on any arch.
P.S. This patch: https://lore.kernel.org/r/20230810141947.1236730-5-arnd@kernel.org is queued up for v6.6-rc1 and should help with the first two warnings.
Bjorn
| |