lkml.org 
[lkml]   [2023]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller
From
On 26/08/2023 23:04, Serge Semin wrote:
>> + clock-names:
>> + items:
>> + - const: stmmaceth
>
> clock-names:
> const: stmmaceth
> ?

The existing syntax is correct. This is a string array.

>
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>
>> + interrupt-names:
>> + items:
>> + - const: macirq
>
> interrupt-names:
> const: macirq
> ?

As well.

>
>> +
>> + loongson,ls1-syscon:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to the syscon containing some extra configurations
>> + including PHY interface mode.
>> +
>
>> + phy-mode:
>> + items:
>> + - enum:
>> + - mii
>> + - rmii
>
> phy-mode:
> enum: ...
> ?

Here indeed, this is a string, not a list, so items are wrong.



Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-08-27 09:58    [W:0.120 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site