lkml.org 
[lkml]   [2023]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next v2 23/28] md: use new apis to suspend array in backlog_store()
    Date
    From: Yu Kuai <yukuai3@huawei.com>

    mddev_create/destroy_serial_pool() will be called from backlog_store(),
    and mddev_suspend() will be called later.

    Prepare to remove the mddev_suspend() from
    mddev_create/destroy_serial_pool().

    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    ---
    drivers/md/md-bitmap.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
    index 7d21e2a5b06e..b3d701c5c461 100644
    --- a/drivers/md/md-bitmap.c
    +++ b/drivers/md/md-bitmap.c
    @@ -2537,7 +2537,7 @@ backlog_store(struct mddev *mddev, const char *buf, size_t len)
    if (backlog > COUNTER_MAX)
    return -EINVAL;

    - rv = mddev_lock(mddev);
    + rv = mddev_suspend_and_lock(mddev);
    if (rv)
    return rv;

    @@ -2562,16 +2562,16 @@ backlog_store(struct mddev *mddev, const char *buf, size_t len)
    if (!backlog && mddev->serial_info_pool) {
    /* serial_info_pool is not needed if backlog is zero */
    if (!mddev->serialize_policy)
    - mddev_destroy_serial_pool(mddev, NULL, false);
    + mddev_destroy_serial_pool(mddev, NULL, true);
    } else if (backlog && !mddev->serial_info_pool) {
    /* serial_info_pool is needed since backlog is not zero */
    rdev_for_each(rdev, mddev)
    - mddev_create_serial_pool(mddev, rdev, false);
    + mddev_create_serial_pool(mddev, rdev, true);
    }
    if (old_mwb != backlog)
    md_bitmap_update_sb(mddev->bitmap);

    - mddev_unlock(mddev);
    + mddev_unlock_and_resume(mddev);
    return len;
    }

    --
    2.39.2
    \
     
     \ /
      Last update: 2023-08-28 04:07    [W:4.068 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site