Messages in this thread | | | Date | Sat, 26 Aug 2023 09:45:39 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [RFC PATCH] Introduce persistent memory pool |
| |
On Tue, Aug 22, 2023 at 06:36:10PM -0700, Stanislav Kinsburskii wrote: > > > +#include <linux/bitmap.h> > > > +#include <linux/memblock.h> > > > +#include <linux/spinlock.h> > > > +#include <linux/types.h> > > > + > > > +#include <linux/pmpool.h> > > > + > > > +#define VERSION 1 > > > > In kernel code does not need versions. > > > > Could you elaborate on this? Should kernel version be used as a backward > compatitbility marker instead?
kernel versions should never be checked for in-kernel code, so I really don't understand the question here sorry.
For code that is in the kernel tree, having "versions" on them (as many drivers used to, and now only a few do), makes no sense, especially with the stable/lts trees getting fixes for them over time as well.
In short, there should not be a need for a "version" anywhere.
thanks,
greg k-h
| |