Messages in this thread | | | Date | Sat, 26 Aug 2023 15:38:11 +0200 | Subject | Re: [PATCH 4/6] media: platform: venus: Add optional LLCC path | From | Konrad Dybcio <> |
| |
On 4.08.2023 23:04, Bryan O'Donoghue wrote: > On 04/08/2023 21:09, Konrad Dybcio wrote: >> Some newer SoCs (such as SM8350) have a third interconnect path. Add >> it and make it optional. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- [...]
> I would scream if someone left me this comment but... > > In probe we have > > video_path = > cpu_cfgpath = > > llc_path = > > suspend > > icc_set_bw(cpu_cfgpath,); > icc_set_bw(llc_path,); > icc_set_bw(video_path,); > > resume > icc_set_bw(video_path,); > icc_set_bw(llc_path,); > icc_set_bw(cpu_cfgpath,); suspend == resume[::-1] is totally the right thing, but I'll reorder things in probe for your viewing pleasure
Konrad
| |