lkml.org 
[lkml]   [2023]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 03/13] ext4: correct return value of ext4_convert_meta_bg
    Date
    Avoid to ignore error in "err".

    Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
    ---
    fs/ext4/resize.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
    index 7cbc695b7005..9cb9ed968599 100644
    --- a/fs/ext4/resize.c
    +++ b/fs/ext4/resize.c
    @@ -1984,9 +1984,7 @@ static int ext4_convert_meta_bg(struct super_block *sb, struct inode *inode)

    errout:
    ret = ext4_journal_stop(handle);
    - if (!err)
    - err = ret;
    - return ret;
    + return err ? err : ret;

    invalid_resize_inode:
    ext4_error(sb, "corrupted/inconsistent resize inode");
    --
    2.30.0
    \
     
     \ /
      Last update: 2023-08-26 11:51    [W:2.826 / U:1.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site