Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 25 Aug 2023 10:39:17 +0200 | Subject | Re: [PATCH 1/7] x86: asm/io.h: Expect immutable pointer in virt_to_phys/isa_virt_to_bus prototypes |
| |
On Thu, Apr 27, 2023 at 7:42 PM Stanislav Kinsburskii <skinsburskii@linux.microsoft.com> wrote:
> From: Stanislav Kinsburskii <stanislav.kinsburskii@gmail.com> > > These two helper functions - virt_to_phys and isa_virt_to_bus - don't need the > address pointer to be mutable. > > In the same time expecting it to be mutable leads to the following build > warning for constant pointers: > > warning: passing argument 1 of ‘virt_to_phys’ discards ‘const’ qualifier from pointer target type > > Signed-off-by: Stanislav Kinsburskii <stanislav.kinsburskii@gmail.com> > CC: Thomas Gleixner <tglx@linutronix.de> > CC: Ingo Molnar <mingo@redhat.com> > CC: Borislav Petkov <bp@alien8.de> > CC: Dave Hansen <dave.hansen@linux.intel.com> > CC: x86@kernel.org > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: Geert Uytterhoeven <geert@linux-m68k.org> > CC: Arnd Bergmann <arnd@arndb.de> > CC: Chris Down <chris@chrisdown.name> > CC: Helge Deller <deller@gmx.de> > CC: Omar Sandoval <osandov@fb.com> > CC: linux-kernel@vger.kernel.org
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
This is the right thing to do.
Yours, Linus Walleij
| |