Messages in this thread | | | Date | Thu, 24 Aug 2023 18:28:11 +0200 | From | Herve Codina <> | Subject | Re: [PATCH v4 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer |
| |
Hi Rob,
On Mon, 21 Aug 2023 15:49:29 -0500 Rob Herring <robh@kernel.org> wrote:
> On Fri, Aug 18, 2023 at 06:39:16PM +0200, Christophe Leroy wrote: > > From: Herve Codina <herve.codina@bootlin.com> > > > > The Lantiq PEF2256 is a framer and line interface component designed to > > fulfill all required interfacing between an analog E1/T1/J1 line and the > > digital PCM system highway/H.100 bus. > > > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > --- > > .../bindings/net/lantiq,pef2256.yaml | 219 ++++++++++++++++++ > > 1 file changed, 219 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml ... > > + '#framer-cells': > > Not a standard binding. Do you need provider specific variable number of > cells?
For the PEF2256, I don't need it. It will be removed in the next iteration.
> > > + const: 0 > > + ...
> > + lantiq,channel-phase: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > > + default: 0 > > + description: > > Need '|' to preserve formatting
Will be fixed in the next iteration.
Best regards, Hervé
| |