Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 24 Aug 2023 18:21:04 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH v6] i2c: designware: Add support for recovery when GPIO need pinctrl. |
| |
Hi Yann,
[...]
> + rinfo->pinctrl = devm_pinctrl_get(dev->dev); > + if (IS_ERR(rinfo->pinctrl)) { > + if (PTR_ERR(rinfo->pinctrl) == -EPROBE_DEFER) > + return PTR_ERR(rinfo->pinctrl); > + > + rinfo->pinctrl = NULL; > + dev_err(dev->dev, "getting pinctrl info failed: bus recovery might not work\n");
I'd still have preferred a dev_warn() here... but it's OK.
> + } else if (!rinfo->pinctrl) { > + dev_dbg(dev->dev, "pinctrl is disabled, bus recovery might not work\n"); > + }
thanks for following up,
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks, Andi
| ![\](/images/icornerr.gif) |