Messages in this thread | | | Date | Thu, 24 Aug 2023 08:00:14 +0200 | Subject | Re: [PATCH v5 05/45] xenbus/backend: dynamically allocate the xen-backend shrinker | From | Juergen Gross <> |
| |
On 24.08.23 05:42, Qi Zheng wrote: > Use new APIs to dynamically allocate the xen-backend shrinker. > > Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> > Reviewed-by: Muchun Song <songmuchun@bytedance.com> > CC: Juergen Gross <jgross@suse.com> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com> > CC: xen-devel@lists.xenproject.org
Acked-by: Juergen Gross <jgross@suse.com>
Just one note: it seems as if most users will set seeks to DEFAULT_SEEKS. Wouldn't it be better to do this in shrinker_alloc() and let only callers who want a different value overwrite that?
Juergen [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |