lkml.org 
[lkml]   [2023]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata()
On Wed, Aug 23, 2023 at 4:44 PM Martin Kaiser <lists@kaiser.cx> wrote:
>
> Andrei Coardos (aboutphysycs@gmail.com) wrote:
>
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
>
> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> > ---
> > drivers/char/hw_random/hisi-rng.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> > diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> > index 96438f85cafa..b6f27566e0ba 100644
> > --- a/drivers/char/hw_random/hisi-rng.c
> > +++ b/drivers/char/hw_random/hisi-rng.c
> > @@ -79,8 +79,6 @@ static int hisi_rng_probe(struct platform_device *pdev)
> > if (!rng)
> > return -ENOMEM;
>
> > - platform_set_drvdata(pdev, rng);
> > -
> > rng->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(rng->base))
> > return PTR_ERR(rng->base);
> > --
> > 2.34.1
>
> This one can go.
>

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>

> Reviewed-by: Martin Kaiser <martin@kaiser.cx>

\
 
 \ /
  Last update: 2023-08-24 10:29    [W:0.046 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site